[Mesa-dev] [PATCH 2/2] configure: Add support for the Intel Vulkan driver

[Kenneth Graunke]

On Thursday, April 14, 2016 1:06:25 PM PDT Jason Ekstrand wrote:
> This adds a --with-vulkan-drivers option with one driver, "intel".  In the
> future, we may add more drivers to this list.
> ---
>  configure.ac | 66 ++++++++++++++++++++++++++++++++++++++++++++
++++++++++++++++
>  1 file changed, 66 insertions(+)
> 
> diff --git a/configure.ac b/configure.ac
> index 40b08d3..3cf8573 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1545,6 +1545,59 @@ if test -n "$with_dri_drivers"; then
>      DRI_DIRS=`echo $DRI_DIRS|tr " " "\n"|sort -u|tr "\n" " "`
>  fi
>  
> +
> +#
> +# Vulkan driver configuration
> +#
> +
> +# Keep this in sync with the --with-vulkan-drivers help string default 
value
> +VULKAN_DRIVERS_DEFAULT="intel"
> +
> +AC_ARG_WITH([vulkan-drivers],
> +    [AS_HELP_STRING([--with-vulkan-drivers@<:@=DIRS...@:>@],
> +        [comma delimited Vulkan drivers list, e.g.
> +        "intel"
> +        @<:@default=intel@:>@])],
> +    [with_vulkan_drivers="$withval"],
> +    [with_vulkan_drivers="$VULKAN_DRIVERS_DEFAULT"])
> +
> +# Doing '--without-vulkan-drivers' will set this variable to 'no'.  Clear 
it
> +# here so that the script doesn't choke on an unknown driver name later.
> +case "$with_vulkan_drivers" in
> +    yes) with_vulkan_drivers="$VULKAN_DRIVERS_DEFAULT" ;;
> +    no) with_vulkan_drivers='' ;;

Put x in front of everything:

case "x$with_vulkan_drivers" in
    xyes) with_vulkan_drivers="$VULKAN_DRIVERS_DEFAULT" ;;
    xno) with_vulkan_drivers='' ;;

> +esac
> +
> +AC_ARG_WITH([vulkan-icddir],
> +    [AS_HELP_STRING([--with-vulkan-icddir=DIR],
> +        [directory for the Vulkan driver icd files @<:@${libdir}/
dri@:>@])],

libdir/dri seems wrong here.

With that fixed, both patches are:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160414/7aed5e3b/attachment.sig>