[Mesa-dev] [PATCH 2/2] i965/surface_formats: Update some formats for more recent gens

Jason Ekstrand jason at jlekstrand.net
Thu Apr 14 21:21:08 UTC 2016


On Thu, Apr 14, 2016 at 2:08 PM, Kenneth Graunke <kenneth at whitecape.org>
wrote:

> On Thursday, April 14, 2016 11:37:57 AM PDT Jason Ekstrand wrote:
> > The surface format table hasn't entirely been kept up-to-date.  This
> commit
> > marks a couple more compressed formats as sampleable on gen8+ and adds
> the
> > A4B4G4R4 format as renderable on gen9.
> > ---
> >  src/mesa/drivers/dri/i965/brw_surface_formats.c | 24 +++++++++++
> +------------
> >  1 file changed, 12 insertions(+), 12 deletions(-)
> >
> > diff --git a/src/mesa/drivers/dri/i965/brw_surface_formats.c b/src/mesa/
> drivers/dri/i965/brw_surface_formats.c
> > index 118b18d..61e1408 100644
> > --- a/src/mesa/drivers/dri/i965/brw_surface_formats.c
> > +++ b/src/mesa/drivers/dri/i965/brw_surface_formats.c
> > @@ -204,7 +204,7 @@ const struct brw_surface_format_info
> surface_formats[] =
> {
> >     SF(50, 50,  x,  x,  x,  x,  x,  x,  x,    x,   P8A8_UNORM_PALETTE0)
> >     SF(50, 50,  x,  x,  x,  x,  x,  x,  x,    x,   P8A8_UNORM_PALETTE1)
> >     SF( x,  x,  x,  x,  x,  x,  x,  x,  x,    x,   A1B5G5R5_UNORM)
> > -   SF( x,  x,  x,  x,  x,  x,  x,  x,  x,    x,   A4B4G4R4_UNORM)
> > +   SF( Y,  Y,  x,  Y, 90,  x,  x,  x,  x,    x,   A4B4G4R4_UNORM)
>
> According to Shared Functions > 3D Sampler > State > SURFACE_STATE, this
> is only filterable on CHV/SKL+.  It is not supported for Chroma Key
> anywhere.  Please make this:
>

empirical evidence suggests that at least sampling works fine on BDW.  I'll
have to do a little research for gen7.


>    SF(90, 90,  x,  x, 90,  x,  x,  x,  x,    x,   A4B4G4R4_UNORM)
>
> With that fixed, these two patches are:
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160414/afb0b5aa/attachment.html>


More information about the mesa-dev mailing list