[Mesa-dev] [PATCH] gallium/swr: confine c++11 flag to swr driver

Chuck Atkins chuck.atkins at kitware.com
Fri Apr 15 16:10:48 UTC 2016


>
> > As LLVM_CXXFLAGS / `llvm-config --cxxflags` already includes std=c++11
>
> Yes, I saw that and considered going that direction, but wasn’t sure if we
> should rely on llvm setting the language version required.
>

Shouldn't you do both? Use LLVM_CXXFLAGS since swr is C++ code including
and using the LLVM C++ API.  Add stc=c++11 since swr itself is using C++ 11
features, regardless of llvm's requirements.  This way, each piece is
defining it's own requirements.  Just relying on LLVM_CXXFLGS is
essentially assuming that LLVM knows how swr needs to be built.  :-/ .  The
end result may be a duplicate std=c++11 entry but it's really more
coincidence.  LLVM could decide that they want to abandon C++11 and not use
it (I know, extremely unlikely) but swr would still need it regardless.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160415/bdfc1d7a/attachment-0001.html>


More information about the mesa-dev mailing list