[Mesa-dev] [PATCH 2/2] configure: Add support for the Intel Vulkan driver

[Jason Ekstrand]

On Fri, Apr 15, 2016 at 10:02 AM, Emil Velikov <emil.l.velikov at gmail.com>
wrote:

> On 14 April 2016 at 21:51, Kenneth Graunke <kenneth at whitecape.org> wrote:
> > On Thursday, April 14, 2016 1:06:25 PM PDT Jason Ekstrand wrote:
> >> This adds a --with-vulkan-drivers option with one driver, "intel".  In
> the
> >> future, we may add more drivers to this list.
> >> ---
> >>  configure.ac | 66 ++++++++++++++++++++++++++++++++++++++++++++
> > ++++++++++++++++
> >>  1 file changed, 66 insertions(+)
> >>
> >> diff --git a/configure.ac b/configure.ac
> >> index 40b08d3..3cf8573 100644
> >> --- a/configure.ac
> >> +++ b/configure.ac
> >> @@ -1545,6 +1545,59 @@ if test -n "$with_dri_drivers"; then
> >>      DRI_DIRS=`echo $DRI_DIRS|tr " " "\n"|sort -u|tr "\n" " "`
> >>  fi
> >>
> >> +
> >> +#
> >> +# Vulkan driver configuration
> >> +#
> >> +
> >> +# Keep this in sync with the --with-vulkan-drivers help string default
> > value
> >> +VULKAN_DRIVERS_DEFAULT="intel"
> >> +
> >> +AC_ARG_WITH([vulkan-drivers],
> >> +    [AS_HELP_STRING([--with-vulkan-drivers@<:@=DIRS...@:>@],
> >> +        [comma delimited Vulkan drivers list, e.g.
> >> +        "intel"
> >> +        @<:@default=intel@:>@])],
> >> +    [with_vulkan_drivers="$withval"],
> >> +    [with_vulkan_drivers="$VULKAN_DRIVERS_DEFAULT"])
> >> +
> >> +# Doing '--without-vulkan-drivers' will set this variable to 'no'.
> Clear
> > it
> >> +# here so that the script doesn't choke on an unknown driver name
> later.
> >> +case "$with_vulkan_drivers" in
> >> +    yes) with_vulkan_drivers="$VULKAN_DRIVERS_DEFAULT" ;;
> >> +    no) with_vulkan_drivers='' ;;
> >
> > Put x in front of everything:
> >
> Which reminds me - what are the advantages of it ? In the gallium
> drivers (where this is derived from) and I've not seen any issues.
> Mostly curious, I'm fine with or without the x.
>
> > case "x$with_vulkan_drivers" in
> >     xyes) with_vulkan_drivers="$VULKAN_DRIVERS_DEFAULT" ;;
> >     xno) with_vulkan_drivers='' ;;
> Please use double quotes for the xno case.
>
> >
> >> +esac
> >> +
> >> +AC_ARG_WITH([vulkan-icddir],
> >> +    [AS_HELP_STRING([--with-vulkan-icddir=DIR],
> >> +        [directory for the Vulkan driver icd files @<:@${libdir}/
> > dri@:>@])],
> >
> > libdir/dri seems wrong here.
> >
> Indeed I'd stick with libdir (as done with the Nvidia driver) or
> libdri/intel. I don't feel too strongly about those.
>

That's the directory for the icd.json file which is basically always
/etc/vulkan/icd.d.  The lib goes in /usr/lib[64] as normal.


> With that
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
>
> -Emil
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160415/d94f4d01/attachment.html>