[Mesa-dev] [PATCH] gallium/util: initialize pipe_framebuffer_state to zeros

[Ilia Mirkin]

Should it instead properly initialize fb->samples/layers?

On Fri, Apr 15, 2016 at 2:15 PM, Brian Paul <brianp at vmware.com> wrote:
> To silence a valgrind uninitialized memory warning.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94955
> Cc: "11.1 11.2" <mesa-stable at lists.freedesktop.org>
> ---
>  src/gallium/auxiliary/util/u_blitter.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxiliary/util/u_blitter.c
> index 3ca2c48..5b22abf 100644
> --- a/src/gallium/auxiliary/util/u_blitter.c
> +++ b/src/gallium/auxiliary/util/u_blitter.c
> @@ -1525,7 +1525,7 @@ void util_blitter_blit_generic(struct blitter_context *blitter,
>  {
>     struct blitter_context_priv *ctx = (struct blitter_context_priv*)blitter;
>     struct pipe_context *pipe = ctx->base.pipe;
> -   struct pipe_framebuffer_state fb_state;
> +   struct pipe_framebuffer_state fb_state = {0};
>     enum pipe_texture_target src_target = src->texture->target;
>     unsigned src_samples = src->texture->nr_samples;
>     unsigned dst_samples = dst->texture->nr_samples;
> --
> 1.9.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev