[Mesa-dev] [Mesa-stable] [PATCH] llvmpipe: (trivial) initialize src1_alpha var to NULL

[Brian Paul]

On 04/15/2016 01:22 PM, sroland at vmware.com wrote:
> From: Roland Scheidegger <sroland at vmware.com>
>
> The blend code would do a conditional assignment based on it, causing valgrind
> to complain. Since that variable was actually unused in this case, this
> doesn't fix anything but the warning.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94955
> Cc: "11.1 11.2" <mesa-stable at lists.freedesktop.org>
> ---
>   src/gallium/drivers/llvmpipe/lp_state_fs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/llvmpipe/lp_state_fs.c b/src/gallium/drivers/llvmpipe/lp_state_fs.c
> index ca0533b..93460a3 100644
> --- a/src/gallium/drivers/llvmpipe/lp_state_fs.c
> +++ b/src/gallium/drivers/llvmpipe/lp_state_fs.c
> @@ -1601,7 +1601,7 @@ generate_unswizzled_blend(struct gallivm_state *gallivm,
>      LLVMValueRef fs_src[4][TGSI_NUM_CHANNELS];
>      LLVMValueRef fs_src1[4][TGSI_NUM_CHANNELS];
>      LLVMValueRef src_alpha[4 * 4];
> -   LLVMValueRef src1_alpha[4 * 4];
> +   LLVMValueRef src1_alpha[4 * 4] = { NULL };
>      LLVMValueRef src_mask[4 * 4];
>      LLVMValueRef src[4 * 4];
>      LLVMValueRef src1[4 * 4];
>

Reviewed-by: Brian Paul <brianp at vmware.com>