[Mesa-dev] [PATCH 7/7] gallium: use unreachable instead of asserts

Grazvydas Ignotas notasas at gmail.com
Sat Apr 16 01:00:16 UTC 2016


Avoids warnings in release builds.

Signed-off-by: Grazvydas Ignotas <notasas at gmail.com>
---
I have no commit access, if this patch is ok, please someone push.

 src/gallium/auxiliary/gallivm/lp_bld_intr.c   | 2 +-
 src/gallium/drivers/radeon/radeon_llvm_emit.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/gallium/auxiliary/gallivm/lp_bld_intr.c b/src/gallium/auxiliary/gallivm/lp_bld_intr.c
index e153389..f806503 100644
--- a/src/gallium/auxiliary/gallivm/lp_bld_intr.c
+++ b/src/gallium/auxiliary/gallivm/lp_bld_intr.c
@@ -84,7 +84,7 @@ lp_format_intrinsic(char *name,
       width = 64;
       break;
    default:
-      assert(0);
+      unreachable("unexpected LLVMTypeKind");
    }
 
    if (length) {
diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.c b/src/gallium/drivers/radeon/radeon_llvm_emit.c
index 7174132..f5a7798 100644
--- a/src/gallium/drivers/radeon/radeon_llvm_emit.c
+++ b/src/gallium/drivers/radeon/radeon_llvm_emit.c
@@ -100,7 +100,7 @@ void radeon_llvm_shader_type(LLVMValueRef F, unsigned type)
 		calling_conv = RADEON_LLVM_AMDGPU_CS;
 		break;
 	default:
-		assert(0);
+		unreachable("invalid shader type");
 	}
 
 	if (HAVE_LLVM >= 0x309)
-- 
2.7.4



More information about the mesa-dev mailing list