[Mesa-dev] [PATCH 2/2] meta: initialize values to avoid random behaviour on error path

Juha-Pekka Heikkila juhapekka.heikkila at gmail.com
Sat Apr 16 19:26:23 UTC 2016


if brw_meta_stencil_blit() errored at wrong place 'target' would
be uninitialized and cause random behaviour on leaving the funtion.

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
---
 src/mesa/drivers/dri/i965/brw_meta_stencil_blit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/brw_meta_stencil_blit.c b/src/mesa/drivers/dri/i965/brw_meta_stencil_blit.c
index 7e04248..3cad165 100644
--- a/src/mesa/drivers/dri/i965/brw_meta_stencil_blit.c
+++ b/src/mesa/drivers/dri/i965/brw_meta_stencil_blit.c
@@ -433,7 +433,7 @@ brw_meta_stencil_blit(struct brw_context *brw,
    struct gl_shader_program *prog;
    struct gl_framebuffer *drawFb = NULL;
    struct gl_renderbuffer *rb = NULL;
-   GLenum target;
+   GLenum target = 0;
 
    _mesa_meta_fb_tex_blit_begin(ctx, &blit);
    /* XXX: Pretend to support stencil textures so _mesa_base_tex_format()
-- 
1.9.1



More information about the mesa-dev mailing list