[Mesa-dev] [PATCH 4/6] gallium: use PIPE_SHADER_* everywhere, remove TGSI_PROCESSOR_*

[Marek Olšák]

On Sat, Apr 16, 2016 at 6:54 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> On Sat, Apr 16, 2016 at 8:50 AM, Marek Olšák <maraeo at gmail.com> wrote:
>> From: Marek Olšák <marek.olsak at amd.com>
>>
>> we should use MESA_SHADER_* everywhere, but we're not ready for that yet
>
> Hmmmm.... not sure if this is right. I thought the idea is that TGSI
> should be its own self-contained encoding of things, and the shader
> type is one of those things. It is, of course, silly that those values
> don't match up to the PIPE_SHADER_* values, but if, let's say, llvm
> wanted to generate TGSI, it'd be odd for it to have to pull in
> anything other than p_shader_tokens.h. (And esp some core mesa thing
> that defines MESA_SHADER_*.)

LLVM can't generate TGSI, because TGSI doesn't have a fixed/stable
format. If you want to import TGSI into LLVM, you need to import the
definitions too.

The shader stage definitions are unlikely to change since all shader
stages are done.

Marek