[Mesa-dev] [PATCH 4/6] gallium: use PIPE_SHADER_* everywhere, remove TGSI_PROCESSOR_*

Marek Olšák maraeo at gmail.com
Sun Apr 17 12:57:45 UTC 2016


On Sun, Apr 17, 2016 at 11:12 AM, Jose Fonseca <jfonseca at vmware.com> wrote:
> On 16/04/16 23:27, Roland Scheidegger wrote:
>>
>> Am 16.04.2016 um 14:50 schrieb Marek Olšák:
>>>
>>> From: Marek Olšák <marek.olsak at amd.com>
>>>
>>> we should use MESA_SHADER_* everywhere, but we're not ready for that yet
>>> ---
>>
>>
>> I think the idea initially was that tgsi is essentially self-contained:
>> you can parse the token stream without any "external" dependencies.
>> Feels a bit unnecessary though.
>>
>> I would object to using MESA_SHADER_ though. Those are clearly defined
>> outside gallium. If you'd wanted to reorder the pipe ones to match the
>> ordering, that would be something different, though pretty sure it would
>> require some code changes and break even more out-of-tree code ;-).
>
>
> Agree.  For sake of non-Mesa state trackers, gallium interface should not
> depend on Mesa/OpenGL etc.

The MESA_SHADER_* enums are used by OpenGL, Vulkan, and NIR, which is
an even more independent IR than TGSI and is going to be supported by Gallium.

Marek


More information about the mesa-dev mailing list