[Mesa-dev] [PATCH 1/7] util: add MAYBE_UNUSED for config dependent variables

[Ian Romanick]

On 04/15/2016 06:00 PM, Grazvydas Ignotas wrote:
> This is mostly for variables that are only used in asserts and cause
> unused-but-set-variable warnings in release builds. Could just use
> UNUSED directly, but MAYBE_UNUSED should be less confusing and is
> similar to what the Linux kernel has.
> 
> And yes __attribute__((unused)) can be used on variables on both GCC 4.2
> (oldest supported by mesa) and clang 3.0 (just some random old version,
> nut sure what's the minimum for mesa).
  not

With that fixed, this patch is

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

> Signed-off-by: Grazvydas Ignotas <notasas at gmail.com>
> ---
> I have no commit access, if this patch is ok, please someone push.
> 
>  src/util/macros.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/util/macros.h b/src/util/macros.h
> index 0c8958f..f081bb8 100644
> --- a/src/util/macros.h
> +++ b/src/util/macros.h
> @@ -204,6 +204,8 @@ do {                       \
>  #define UNUSED
>  #endif
>  
> +#define MAYBE_UNUSED UNUSED
> +
>  #ifdef HAVE_FUNC_ATTRIBUTE_WARN_UNUSED_RESULT
>  #define MUST_CHECK __attribute__((warn_unused_result))
>  #else
>