[Mesa-dev] [PATCH 31/41] glapi: glX_proto_common.py: return variable from glx_print_proto.size_call

Ian Romanick idr at freedesktop.org
Tue Apr 19 23:31:00 UTC 2016


On 03/31/2016 05:04 PM, Dylan Baker wrote:
> The variable has the same value as the explicit None return, but makes
> it clearer what's going on.

If we're going to do that, I think it makes sense to make the other
returns be breaks instead.

> 
> Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
> ---
>  src/mapi/glapi/gen/glX_proto_common.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mapi/glapi/gen/glX_proto_common.py b/src/mapi/glapi/gen/glX_proto_common.py
> index b1db0f7..d14d43a 100644
> --- a/src/mapi/glapi/gen/glX_proto_common.py
> +++ b/src/mapi/glapi/gen/glX_proto_common.py
> @@ -70,7 +70,7 @@ class glx_print_proto(gl_XML.gl_print_base):
>  
>                      return compsize
>  
> -        return None
> +        return compsize
>  
>      def emit_packet_size_calculation(self, f, bias):
>          # compsize is only used in the command size calculation if
> 



More information about the mesa-dev mailing list