[Mesa-dev] [PATCH 41/41] glapi: gl_x86-64_asm.py: use _ for unused variable

Ian Romanick idr at freedesktop.org
Tue Apr 19 23:46:37 UTC 2016


This patch is

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

On 03/31/2016 05:04 PM, Dylan Baker wrote:
> Don't assign variables that aren't actually used, just put them in _,
> the python unused variable.
> 
> Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
> ---
>  src/mapi/glapi/gen/gl_x86-64_asm.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mapi/glapi/gen/gl_x86-64_asm.py b/src/mapi/glapi/gen/gl_x86-64_asm.py
> index bfd1270..8887bfb9 100644
> --- a/src/mapi/glapi/gen/gl_x86-64_asm.py
> +++ b/src/mapi/glapi/gen/gl_x86-64_asm.py
> @@ -35,7 +35,7 @@ import license
>  
>  
>  def should_use_push(registers):
> -    for [reg, offset] in registers:
> +    for reg, _ in registers:
>          if reg[1:4] == "xmm":
>              return False
>  
> 



More information about the mesa-dev mailing list