[Mesa-dev] [PATCH] dri2: Check for dummyContext to see if the glx_context is valid

Stefan Dirsch sndirsch at suse.de
Thu Apr 21 10:10:35 UTC 2016


On Thu, Apr 21, 2016 at 04:22:26PM +0900, Michel Dänzer wrote:
> On 20.04.2016 19:38, Stefan Dirsch wrote:
> > According to the comments in src/glx/glxcurrent.c __glXGetCurrentContext()
> > always returns a valid pointer. If no context is made current, it will
> > contain dummyContext. Thus a test for NULL will always fail.
> > 
> > Patch author: Egbert Eich <eich at suse.com>

done.

> Please set the Git author field itself to Egbert Eich <eich at suse.com> then.
>
> With that fixed,
> 
> Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>

Wow! I've added this to the commit message as well and resent the patch.

https://lists.freedesktop.org/archives/mesa-dev/2016-April/113975.html

> Do you need somebody to push this patch for you?

If you could help with that, this would be very useful and appreciated.

> P.S. Looks like at least glx_dri3_get_dri_context may need the same
> treatment?

Took care of this as well and sent the patch to the list.

https://lists.freedesktop.org/archives/mesa-dev/2016-April/113976.html

Thanks,
Stefan

Public Key available
------------------------------------------------------
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0            Maxfeldstraße 5
FAX: 0911-740 53 479          D-90409 Nürnberg
http://www.suse.de            Germany 
---------------------------------------------------------------
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---------------------------------------------------------------


More information about the mesa-dev mailing list