[Mesa-dev] [PATCH 2/2] anv: use PUBLIC macro to annotate symbols

Emil Velikov emil.l.velikov at gmail.com
Thu Apr 21 12:15:00 UTC 2016


From: Emil Velikov <emil.velikov at collabora.com>

The symbols are part of an the VK_DEBUG_MARKER_EXT device extension thus
they should be provided statically.

Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
---
Right ? Afaics one should even mention the extension name, version plus 
entry points via the layer section in the json. Then again since the 
extension isn't implemented yet, we could spare the actual json change.

-Emil

 src/intel/vulkan/anv_device.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
index d6e74d3..03d965f 100644
--- a/src/intel/vulkan/anv_device.c
+++ b/src/intel/vulkan/anv_device.c
@@ -1775,21 +1775,23 @@ void anv_DestroyFramebuffer(
    anv_free2(&device->alloc, pAllocator, fb);
 }
 
+PUBLIC
 void vkCmdDbgMarkerBegin(
     VkCommandBuffer                              commandBuffer,
-    const char*                                 pMarker)
-   __attribute__ ((visibility ("default")));
+    const char*                                 pMarker);
 
+PUBLIC
 void vkCmdDbgMarkerEnd(
-   VkCommandBuffer                              commandBuffer)
-   __attribute__ ((visibility ("default")));
+   VkCommandBuffer                              commandBuffer);
 
+PUBLIC
 void vkCmdDbgMarkerBegin(
     VkCommandBuffer                              commandBuffer,
     const char*                                 pMarker)
 {
 }
 
+PUBLIC
 void vkCmdDbgMarkerEnd(
     VkCommandBuffer                              commandBuffer)
 {
-- 
2.8.0



More information about the mesa-dev mailing list