[Mesa-dev] [PATCH] gallivm: fix bogus argument order to lp_build_sample_mipmap function

[Jose Fonseca]

On 21/04/16 02:04, sroland at vmware.com wrote:
> From: Roland Scheidegger <sroland at vmware.com>
>
> Screwed up since 0753b135f6e83b171d8a1b08aea967374f3542bc.
>
> (Only an issue with different min/mag filters, and then only in some cases,
> which is probably why it went unnoticed for quite a while.
> The effect should have simply been nearest mip filter instead of linear, iff
> min was nearest, mag was linear, and all pixels hit the mignifying path.)
>
> Fixes a bunch of dEQP failures.
>
> Cc: "11.1 11.2" <mesa-stable at lists.freedesktop.org>
> ---
>   src/gallium/auxiliary/gallivm/lp_bld_sample_soa.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/gallium/auxiliary/gallivm/lp_bld_sample_soa.c b/src/gallium/auxiliary/gallivm/lp_bld_sample_soa.c
> index 83db0ed..1727105 100644
> --- a/src/gallium/auxiliary/gallivm/lp_bld_sample_soa.c
> +++ b/src/gallium/auxiliary/gallivm/lp_bld_sample_soa.c
> @@ -2256,8 +2256,8 @@ lp_build_sample_general(struct lp_build_sample_context *bld,
>                * All pixels require just nearest filtering, which is way
>                * cheaper than linear, hence do a separate path for that.
>                */
> -            lp_build_sample_mipmap(bld, PIPE_TEX_FILTER_NEAREST, FALSE,
> -                                   mip_filter_for_nearest,
> +            lp_build_sample_mipmap(bld, PIPE_TEX_FILTER_NEAREST,
> +                                   mip_filter_for_nearest, FALSE,
>                                      coords, offsets,
>                                      ilevel0, ilevel1, lod_fpart,
>                                      texels);
>

If we were using an enum for PIPE_TEX_FILTER_ and parameters the 
compiler might have warned us here (at least a C++ definitely would, not 
entirely sure about C).  After Marek's enum series is committed we 
should start using these enums.

Reviewed-by: Jose Fonseca <jfonseca at vmware.com>