[Mesa-dev] [PATCH] include/GL: fix the interop header for a --disable-glx build
Chuck Atkins
chuck.atkins at kitware.com
Thu Apr 21 19:08:13 UTC 2016
>
> >> Drop the includes altogether, and forward declare the needed symbols.
>
But then you end up with forward declarations of symbols that may not even
exist.
> > Why not use the configure.ac-based approach suggested by Chuck?
>
> Few reasons come to mind:
>
> Not to mention that every user will need a check analogous to the one
> in configure.ac.
>
There's already extra -D requirements that get pushed into the generated
.pc files. It will get populated by the @GL_PC_CFLAGS@ configure
variable. A consumer wouldn't need to know how to check for GLX
enablement, just use the flags they're given.
I don't particularly like arbitrarily adding -D flags either though so I
get where you're coming from. Typically these sorts of things would get
pushed into a config.h.in generated at configure time and installed with
the rest of the headers but it seems silly to do add a conf header like
that when there's not one already for just this change.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160421/a8b9dbf1/attachment.html>
More information about the mesa-dev
mailing list