[Mesa-dev] [PATCH] egl: android: add dma-buf fd support

[Varad Gautam]

> On 20 April 2016 at 03:52, Rob Herring <robh at kernel.org> wrote:
>> On Tue, Apr 19, 2016 at 8:03 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>>> Looking at this patch and Varad's work
>>> there a hunk missing here [1]. Did you not come across the issue in
>>> question ?
>>
>> I don't think it is a real issue. I traced the code for
>> createNewDrawable and it only saves dri2_surf ptr, but never
>> references the contents of it. And I didn't find any problems when
>> reverting it and testing, so I dropped that patch.
>>
> Fair enough. Varad can you confirm if you've seen any actual uses for
> [1] or was it based upon code observation ?
>

We never reference dri2_surf in the createNewDrawable path, so I guess
it was just a precautionary measure at the time. We can do away with
the patch.

Thanks,
Varad

>>>
>>> Apologies that I'm the bearer of bad news and thank you for working on this.
>>
>> Apologies for pretending I know what I'm doing. :)
>>
> Not a problem. It's not like you've done any of it with ill intent.
> Plus I'm happy to share as much knowledge I have in the area.
>
> -Emil
>
> [1] https://github.com/varadgautam/mesa/commit/96c533fd62db4bb21f0a778ad16848da2df24fd6