[Mesa-dev] [PATCH] i965: don't lower mod() in glsl ir

[Samuel Iglesias Gonsálvez]

On 22/04/16 09:34, Kenneth Graunke wrote:
> On Friday, April 22, 2016 9:24:01 AM PDT Samuel Iglesias Gonsálvez wrote:
>>
>> On 22/04/16 08:44, Kenneth Graunke wrote:
>>> On Friday, April 22, 2016 7:32:43 AM PDT Samuel Iglesias Gonsálvez wrote:
>>>> NIR will lower it in nir_opt_algebraic.
>>>>
>>>> Signed-off-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
>>>> ---
>>>>  src/mesa/drivers/dri/i965/brw_link.cpp | 1 -
>>>>  1 file changed, 1 deletion(-)
>>>>
>>>> diff --git a/src/mesa/drivers/dri/i965/brw_link.cpp b/src/mesa/drivers/
> dri/
>>> i965/brw_link.cpp
>>>> index bb7e1eb..ee62ada 100644
>>>> --- a/src/mesa/drivers/dri/i965/brw_link.cpp
>>>> +++ b/src/mesa/drivers/dri/i965/brw_link.cpp
>>>> @@ -105,7 +105,6 @@ process_glsl_ir(gl_shader_stage stage,
>>>>     brw_lower_packing_builtins(brw, shader->Stage, shader->ir);
>>>>     do_mat_op_to_vec(shader->ir);
>>>>     lower_instructions(shader->ir,
>>>> -                      MOD_TO_FLOOR |
>>>>                        DIV_TO_MUL_RCP |
>>>>                        SUB_TO_ADD_NEG |
>>>>                        EXP_TO_EXP2 |
>>>>
>>>
>>> Any shader-db impact?
>>>
>>
>> Nope :-)
>>
>> total instructions in shared programs: 6227051 -> 6227051 (0.00%)
>> instructions in affected programs:     0 -> 0
>> total loops in shared programs:        1978 -> 1978 (0.00%)
>> helped:                                0
>> HURT:                                  0
>> GAINED:                                0
>> LOST:                                  0
>>
>> Sam
> 
> Great :)
> 
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
> 
> It might be worth adding "No change in shader-db." to the commit message.
> 

I will do it.

Thanks for the review!

Sam