[Mesa-dev] [PATCH 01/13] i965: Add a dependency on libisl

Emil Velikov emil.l.velikov at gmail.com
Fri Apr 22 16:31:29 UTC 2016


On 22 April 2016 at 16:08, Jonathan Gray <jsg at jsg.id.au> wrote:
> It is worth noting that the isl code extensively requires designated
> initialisers on anonymous structs.  It isn't clear to me when gcc introduced
> support for this but it isn't in 4.2.
>
I think it should work for GCC 4.2 with -fms-extensions. We used to
set -std=gnu99 for pre 4.6 which effectively enables it the extension.
Can you double-check ?

> Would you accept patches to remove them?
While I cannot comment if they're OK with the idea, there might be
some confusion on the topic.
There is anonymous and named. I believe developers were against the
latter. Examples form [1]

    struct bar { int i; }; // (1) unnamed, but tagged, ie *not* anonymous
    struct { int j; };     // (2) unnamed, but anonymous
    struct { int k; } baz; // (3) named, but not tagged

Fwiw it would be great to use the more portable solution. Would C11
buy us anything ?


Thanks
Emil

[1] http://stackoverflow.com/questions/5063548/initialization-of-anonymous-structures-or-unions-in-c1x


More information about the mesa-dev mailing list