[Mesa-dev] [PATCH] anv_device: Set the compressed texture feature flags correctly

Kenneth Graunke kenneth at whitecape.org
Fri Apr 22 23:17:54 UTC 2016


On Monday, April 18, 2016 2:33:38 PM PDT Nanley Chery wrote:
> From: Nanley Chery <nanley.g.chery at intel.com>
> 
> Sampling from an ETC2 texture is supported from Gen8 onwards.
> While ASTC_LDR is supported on Gen9, the logic to handle such
> formats has not yet been implemented in the driver.
> 
> Fixes dEQP-VK.api.info.format_properties.compressed_formats.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94896
> Signed-off-by: Nanley Chery <nanley.g.chery at intel.com>
> ---
>  src/intel/vulkan/anv_device.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
> index e477fe1..5433dd3 100644
> --- a/src/intel/vulkan/anv_device.c
> +++ b/src/intel/vulkan/anv_device.c
> @@ -380,8 +380,8 @@ void anv_GetPhysicalDeviceFeatures(
>        .alphaToOne                               = true,
>        .multiViewport                            = true,
>        .samplerAnisotropy                        = false, /* FINISHME */
> -      .textureCompressionETC2                   = true,
> -      .textureCompressionASTC_LDR               = true,
> +      .textureCompressionETC2                   = pdevice->info->gen >= 8,
> +      .textureCompressionASTC_LDR               = false, /* FINISHME */
>        .textureCompressionBC                     = true,
>        .occlusionQueryPrecise                    = true,
>        .pipelineStatisticsQuery                  = false,
> 

ETC2 is also supported on Baytrail.  Otherwise, looks good to me.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160422/5c925c56/attachment.sig>


More information about the mesa-dev mailing list