[Mesa-dev] [RFC 1/5] wayland-drm: add a few lovely notes about future work.

[Daniel Stone]

Hi,

On 21 April 2016 at 13:24, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> diff --git a/src/egl/wayland/wayland-drm/wayland-drm.h b/src/egl/wayland/wayland-drm/wayland-drm.h
> index 7892d56..33d7fd4 100644
> --- a/src/egl/wayland/wayland-drm/wayland-drm.h
> +++ b/src/egl/wayland/wayland-drm/wayland-drm.h
> @@ -3,6 +3,10 @@
>
>  #include <wayland-server.h>
>
> +// XXX: These formats should go. One should use the auto-generated ones.
> +// XXX: Ensure that no-one but wayland-egl and/or wayland EGL platform codes
> +// includes this. Doing so give us an ABI, which we don't check but perhaps we should.
> +
>  #ifndef WL_DRM_FORMAT_ENUM
>  #define WL_DRM_FORMAT_ENUM
>  enum wl_drm_format {

Indeed, this is already provided by wayland-drm-*-protocol.h, and only
used in places which may include those files.

Reviewed-by: Daniel Stone <daniels at collabora.com>

Cheers,
Daniel