[Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

[Daniel Stone]

Hi,

On 25 April 2016 at 15:25, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 25 April 2016 at 13:46, Daniel Stone <daniel at fooishbar.org> wrote:
>> On 23 April 2016 at 03:08, Rob Herring <robh at kernel.org> wrote:
>>> I'm not using GBM_BO_USE_WRITE and that is not a condition for mapping
>>> given that flag is tied to cursors (according to comments) and gives
>>> dumb buffers. Also of note, if gralloc flags are set for r/w often,
>>> then I request a linear buffer. Here's the gralloc side:
>>
>> Right, I wouldn't take GBM_BO_USE_WRITE to have much of an effect on
>> mappings, as it pessimises allocation like you say.
>>
> Ftr, I'm not objecting as to how things are done. Just saying that
> things should be blindly obvious as one reads the documentation alone.
> I'm assuming that most people involved are "tainted" (the know to a
> level how things are implemented) thus things are clearer for them.

And on that, we agree. :)

Cheers,
Daniel