[Mesa-dev] [PATCH] vbo: Return INVALID_OPERATION during draw with a mapped buffer

[Kenneth Graunke]

On Monday, April 25, 2016 5:54:28 PM PDT Jordan Justen wrote:
> Fixes the OpenGLES 3.1 CTS:
>  * ESEXT-CTS.draw_elements_base_vertex_tests.invalid_mapped_bos
> 
> Because this is triggering the error message after the normal API
> validation phase, we don't have the API function name available, and
> therefore we generate an error message that is a little confusing:
> 
> Mesa: User error: GL_INVALID_OPERATION in Vertex buffers are mapped during 
draw call!
> 
[snip]
>
> @@ -421,6 +421,14 @@ vbo_bind_arrays(struct gl_context *ctx)
>           exec->validating = GL_FALSE;
>        }
>     }
> +
> +   if (!check_buffers_are_unmapped(ctx)) {
> +      _mesa_error(ctx, GL_INVALID_OPERATION,
> +                  "Vertex buffers are mapped during draw call!");

You could change this to:

"draw call (vertex buffers are mapped)"

so that it would read:

Mesa: User error: GL_INVALID_OPERATION in draw call (vertex buffers are 
mapped)

which is a little less confusing.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160426/d1217e59/attachment-0001.sig>