[Mesa-dev] [PATCH 2/3] radeonsi: remove needless cache flushes at the end of CP DMA operations

Nicolai Hähnle nhaehnle at gmail.com
Wed Apr 27 23:45:10 UTC 2016


Patches 1 & 2 are

Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>

On 22.04.2016 03:52, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
>
> not needed AFAIK
> ---
>   src/gallium/drivers/radeonsi/si_cp_dma.c | 8 --------
>   1 file changed, 8 deletions(-)
>
> diff --git a/src/gallium/drivers/radeonsi/si_cp_dma.c b/src/gallium/drivers/radeonsi/si_cp_dma.c
> index 38e0ee6..bca9cc5 100644
> --- a/src/gallium/drivers/radeonsi/si_cp_dma.c
> +++ b/src/gallium/drivers/radeonsi/si_cp_dma.c
> @@ -206,10 +206,6 @@ static void si_clear_buffer(struct pipe_context *ctx, struct pipe_resource *dst,
>   		va += byte_count;
>   	}
>
> -	/* Flush the caches again in case the 3D engine has been prefetching
> -	 * the resource. */
> -	sctx->b.flags |= flush_flags;
> -
>   	if (tc_l2_flag)
>   		r600_resource(dst)->TC_L2_dirty = true;
>   }
> @@ -336,10 +332,6 @@ void si_copy_buffer(struct si_context *sctx,
>   	if (realign_size)
>   		si_cp_dma_realign_engine(sctx, realign_size);
>
> -	/* Flush the caches again in case the 3D engine has been prefetching
> -	 * the resource. */
> -	sctx->b.flags |= flush_flags;
> -
>   	if (tc_l2_flag)
>   		r600_resource(dst)->TC_L2_dirty = true;
>   }
>


More information about the mesa-dev mailing list