[Mesa-dev] [SQUASH] i965: Zero out query buffer done bit

[Kenneth Graunke]

On Wednesday, April 27, 2016 1:48:16 PM PDT Jordan Justen wrote:
> On 2016-04-27 12:28:15, Kenneth Graunke wrote:
> > Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> > ---
> >  src/mesa/drivers/dri/i965/brw_context.h   |  2 ++
> >  src/mesa/drivers/dri/i965/brw_queryobj.c  |  4 ++--
> >  src/mesa/drivers/dri/i965/gen6_queryobj.c | 30 +++++++++++++++++++++++++
+----
> >  3 files changed, 30 insertions(+), 6 deletions(-)
> > 
> > Jordan,
> > 
> > I'm pretty sure you need to zero out the "Done?" bit in query->bo.  The 
BOs
> > we allocate aren't guaranteed to be zero...so we may end up copying 
garbage
> > to the MI_PREDICATE registers, rather than 0/1 as we wanted.
> 
> I think in gen6_begin_query, when we call:
> 
>    /* For ARB_query_buffer_object: The result is not available */
>    set_query_availability(brw, query, false);
> 
> it should insert a CS write immediate to set it to 0. (Only for
> 'pipelined' queries.) Will that work?
> 
> -Jordan

Right...I forgot about that :)

That should work fine.  Feel free to ignore this squash request then.

--Ken
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160427/fe3e4e5f/attachment.sig>