[Mesa-dev] [PATCH 7/7] i965: Remove inst_info table from brw_eu_validate.

Matt Turner mattst88 at gmail.com
Thu Apr 28 18:52:18 UTC 2016


On Thu, Apr 28, 2016 at 11:35 AM, Matt Turner <mattst88 at gmail.com> wrote:
> On Thu, Apr 28, 2016 at 12:19 AM, Francisco Jerez <currojerez at riseup.net> wrote:
>> At this point this doesn't contain any information not already in the
>> opcode_desc tables, the validation code can just call
>> brw_opcode_desc() in order to find out whether an instruction is
>> supported by the device.
>
> NAK. This table is intended to handle things other than the supported
> generation -- I sent patches that add more fields but they're in some
> review limbo state.

I think I actually like this if you take my feedback on 4/7. Since you
have to add a gen field, if you integrate the field used here into the
opcode_descs table, I'm in favor of combining the tables.


More information about the mesa-dev mailing list