[Mesa-dev] [PATCH] st/omx: don't return early in vid_enc_EncodeFrame()

Emil Velikov emil.l.velikov at gmail.com
Fri Apr 29 15:37:40 UTC 2016

Hi Alex,

On 29 April 2016 at 15:30, Alex Deucher <alexdeucher at gmail.com> wrote:
> On Fri, Apr 29, 2016 at 8:56 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> From: Emil Velikov <emil.velikov at collabora.com>
>> Earlier commit plugged a memory leak, although it missed a pair of
>> brackets. Thus we unconditionally returned even in the case of no error.
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95203
>> Fixes: b87856d25d1 ("st/omx: Fix resource leak on OMX_ErrorNone")
>> Cc: Andy Furniss <adf.lists at gmail.com>
>> Cc: Robert Foss <robert.foss at collabora.com>
>> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
>> ---
>> What an embarassing bug - missing brackets. Andy can you confirm that it
>> resolves the issue ?
> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
Sorry I've missed your review and pushed the fix with Andy and Rob's tags.


More information about the mesa-dev mailing list