[Mesa-dev] [PATCH] mesa: simplify _mesa_Lightfv

[Brian Paul]

On 04/29/2016 08:24 AM, Thomas Faller wrote:
> Signed-off-by: Thomas Faller <tfaller1 at gmx.de>
> ---
>   src/mesa/main/light.c | 10 ----------
>   1 file changed, 10 deletions(-)
>
> diff --git a/src/mesa/main/light.c b/src/mesa/main/light.c
> index 14b4b04..4a8dee3 100644
> --- a/src/mesa/main/light.c
> +++ b/src/mesa/main/light.c
> @@ -250,17 +250,7 @@ _mesa_Lightfv( GLenum light, GLenum pname, const
> GLfloat *params )
>         }
>         break;
>      case GL_CONSTANT_ATTENUATION:
> -      if (params[0] < 0.0F) {
> -     _mesa_error(ctx, GL_INVALID_VALUE, "glLight");
> -     return;
> -      }
> -      break;
>      case GL_LINEAR_ATTENUATION:
> -      if (params[0] < 0.0F) {
> -     _mesa_error(ctx, GL_INVALID_VALUE, "glLight");
> -     return;
> -      }
> -      break;
>      case GL_QUADRATIC_ATTENUATION:
>         if (params[0] < 0.0F) {
>        _mesa_error(ctx, GL_INVALID_VALUE, "glLight");

Reviewed-by: Brian Paul <brianp at vmware.com>

Need me to commit/push this for you?

-Brian