[Mesa-dev] [PATCH] gallium/util: fix error detection in s3tc init

[Jose Fonseca]

On 30/07/16 19:39, Jan Ziak wrote:
> Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0x9b at gmail.com>
> ---
>  src/gallium/auxiliary/util/u_format_s3tc.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/src/gallium/auxiliary/util/u_format_s3tc.c b/src/gallium/auxiliary/util/u_format_s3tc.c
> index 8c4f215..7e51c4d 100644
> --- a/src/gallium/auxiliary/util/u_format_s3tc.c
> +++ b/src/gallium/auxiliary/util/u_format_s3tc.c
> @@ -139,11 +139,11 @@ util_format_s3tc_init(void)
>     tx_compress_dxtn =
>           util_dl_get_proc_address(library, "tx_compress_dxtn");
>
> -   if (!util_format_dxt1_rgb_fetch ||
> -       !util_format_dxt1_rgba_fetch ||
> -       !util_format_dxt3_rgba_fetch ||
> -       !util_format_dxt5_rgba_fetch ||
> -       !util_format_dxtn_pack) {
> +   if (!fetch_2d_texel_rgb_dxt1 ||
> +       !fetch_2d_texel_rgba_dxt1 ||
> +       !fetch_2d_texel_rgba_dxt3 ||
> +       !fetch_2d_texel_rgba_dxt5 ||
> +       !tx_compress_dxtn) {
>        debug_printf("couldn't reference all symbols in " DXTN_LIBNAME
>                     ", software DXTn compression/decompression "
>                     "unavailable\n");
>

Good catch.

Reviewed-by: Jose Fonseca <jfonseca at vmware.com>