[Mesa-dev] [PATCH v2] i965: use mt->offset in intel_miptree_map_movntdqa().

Chad Versace chad at kiwitree.net
Wed Aug 3 00:08:27 UTC 2016


On 08/02/2016 05:03 PM, Haixia Shi wrote:
> We need to include mt->offset in the calculation of src pointer because its
> value may be non-zero, for example in a cubemap texture.
>
> Signed-off-by: Haixia Shi <hshi at chromium.org>
> Cc: Jason Ekstrand <jason.ekstrand at intel.com>
> Cc: kenneth.w.graunke at intel.com
> Cc: Chad Versace <chad at kiwitree.net>
>
> Change-Id: I461ad5b204626d5a1c45611fc6b63735dcf29f63
> ---
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> index a988221..8e7c44c 100644
> --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> +++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> @@ -2462,6 +2462,9 @@ intel_miptree_map_movntdqa(struct brw_context *brw,
>     void *src = intel_miptree_map_raw(brw, mt);
>     if (!src)
>        return;
> +
> +   src += mt->offset;
> +
>     src += image_y * mt->pitch;
>     src += image_x * mt->cpp;

Ok. That looks better. For real this time,
Reviewed-by: Chad Versace <chad at kiwitree.net>



More information about the mesa-dev mailing list