[Mesa-dev] [PATCH] nir: add missing x swizzle in nir_print()

Matt Turner mattst88 at gmail.com
Wed Aug 3 00:34:30 UTC 2016


On Tue, Aug 2, 2016 at 5:28 PM, Timothy Arceri
<timothy.arceri at collabora.com> wrote:
> Currently we only print the swizzle if the components are not
> used in order. This means x is not printed when it is the only
> component used. By checking if the last component is used we
> can print the swizzle for this case.

I agree. I've found this really annoying.

I sent a patch "[PATCH] nir: Always print non-identity swizzles." in
September of last year after my first attempt to fix it was met with
resistance. Unfortunately no one, even those who complained about v1,
replied.

Perhaps I silence is agreement and I should have just pushed it.

What do you think of that patch? Regardless, I definitely want to see
this fixed this time.


More information about the mesa-dev mailing list