[Mesa-dev] [PATCH 0/3] Destroy Present event contexts

[Michel Dänzer]

On 02.08.2016 23:01, Leo Liu wrote:
> On 08/01/2016 10:20 PM, Michel Dänzer wrote:
>> On 28.07.2016 18:34, Michel Dänzer wrote:
>>> Running XTS (the X test suite) on Xephyr using glamor running on Xorg,
>>> I stumbled upon an issue:
>>>
>>> * XTS causes Xephyr to keep resetting and starting new server
>>> generations
>>> * glamor creates a new GLX context for each server generation but
>>> re-uses
>>>    the same window
>>>
>>> This caused Xorg to accumulate stale Present event contexts from
>>> previous
>>> GLX contexts, so it kept getting slower due to sending out an increasing
>>> number of copies of the same Present events to Xephyr.
>>>
>>> The first patch fixes this problem, and the other two patches apply the
>>> same principle to the other places using Present event contexts.
>>>
>>> Note that destroying a Present event context doesn't actually work
>>> without this xserver fix:
>>>
>>> https://patchwork.freedesktop.org/patch/101430/
>> v2 of that fix has landed in xserver master.
>>
>>
>>> But these changes shouldn't make things any worse than they already
>>> are with X servers lacking that fix.
>>>
>>> [PATCH 1/3] loader/dri3: Destroy Present event context when
>>> [PATCH 2/3] vl/dri3: Destroy Present event context when destroying
>>> [PATCH 3/3] anv/x11: Destroy Present event context when destroying
>> Any comments on the v2 patches? Unless there are any objections, I'm
>> going to push v2 of patches 1 & 2 later this week. I'm not going to push
>> patch 3 myself without getting at least a Tested-by: from somebody.
> 
> Patch 2 is:
> Tested and Reviewed by: Leo Liu <leo.liu at amd.com>

Thank you, Leo.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer