[Mesa-dev] [PATCH 28/95] i965/vec4: fix register allocation for 64-bit undef sources

Francisco Jerez currojerez at riseup.net
Wed Aug 3 00:59:42 UTC 2016


Iago Toral Quiroga <itoral at igalia.com> writes:

> ---
>  src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp b/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp
> index 7b8e30d..65fa057 100644
> --- a/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp
> @@ -2009,7 +2009,8 @@ vec4_visitor::nir_emit_texture(nir_tex_instr *instr)
>  void
>  vec4_visitor::nir_emit_undef(nir_ssa_undef_instr *instr)
>  {
> -   nir_ssa_values[instr->def.index] = dst_reg(VGRF, alloc.allocate(1));
> +   nir_ssa_values[instr->def.index] =
> +      dst_reg(VGRF, alloc.allocate(instr->def.bit_size / 32));

I think you want to use DIV_ROUND_UP here instead, with that fixed:

Reviewed-by: Francisco Jerez <currojerez at riseup.net>

>  }
>  
>  }
> -- 
> 2.7.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160802/841c1119/attachment.sig>


More information about the mesa-dev mailing list