[Mesa-dev] [PATCH 0/4] egl/*: Set disp->DriverData to NULL on error
Nicolas Boichat
drinkcat at chromium.org
Thu Aug 4 02:07:50 UTC 2016
egl/x11 fixup has already be sent here:
https://patchwork.freedesktop.org/patch/101934/
Compile-tested only (on android only).
I was first thinking of modifying most functions in egl_dri2.c to take in
dri2_egl_display *dri2_dpy instead of _EGLDisplay *disp as parameter, so
we do not need to set disp->DriverData early in the dri_initialize_* functions.
But there are some functions that do need disp as well:
- dri2_add_config, to call _eglInitConfig (disp->DriverData does not need to be
set), and to check if extensions are supported.
- dri2_setup_screen (similar reasons)
Ideas to untangle this are welcome. In the mean time, this patch series should
fix crashes and a piglit test.
Nicolas Boichat (4):
egl/wayland: Set disp->DriverData to NULL on error
egl/surfaceless: Set disp->DriverData to NULL on error
egl/drm: Set disp->DriverData to NULL on error
egl/android: Set dpy->DriverData to NULL on error
src/egl/drivers/dri2/platform_android.c | 1 +
src/egl/drivers/dri2/platform_drm.c | 1 +
src/egl/drivers/dri2/platform_surfaceless.c | 1 +
src/egl/drivers/dri2/platform_wayland.c | 2 ++
4 files changed, 5 insertions(+)
--
2.8.0.rc3.226.g39d4020
More information about the mesa-dev
mailing list