[Mesa-dev] [PATCH 1/6] gallium/radeon: change the vendor string to Advanced Micro Devices, Inc.

Axel Davy axel.davy at ens.fr
Sat Aug 6 22:01:56 UTC 2016


Hi,

This looks like it will perturb driver detection of already written games.

For example from the dolphin sources, this change would make them detect 
catalyst as driver.

As it is known workarounds are applied depending on the driver detected, 
or some features are disabled,
I believe it isn't a good change.

Yours,

Axel

On 06/08/2016 20:04, Marek Olšák a écrit :
> From: Marek Olšák <marek.olsak at amd.com>
>
> ---
>   src/gallium/drivers/radeon/r600_pipe_common.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src/gallium/drivers/radeon/r600_pipe_common.c
> index 1c56e6e..8a9ab94 100644
> --- a/src/gallium/drivers/radeon/r600_pipe_common.c
> +++ b/src/gallium/drivers/radeon/r600_pipe_common.c
> @@ -598,21 +598,21 @@ static const struct debug_named_value common_debug_options[] = {
>   	{ "mono", DBG_MONOLITHIC_SHADERS, "Use old-style monolithic shaders compiled on demand" },
>   	{ "noce", DBG_NO_CE, "Disable the constant engine"},
>   	{ "unsafemath", DBG_UNSAFE_MATH, "Enable unsafe math shader optimizations" },
>   	{ "nodccfb", DBG_NO_DCC_FB, "Disable separate DCC on the main framebuffer" },
>   
>   	DEBUG_NAMED_VALUE_END /* must be last */
>   };
>   
>   static const char* r600_get_vendor(struct pipe_screen* pscreen)
>   {
> -	return "X.Org";
> +	return "Advanced Micro Devices, Inc.";
>   }
>   
>   static const char* r600_get_device_vendor(struct pipe_screen* pscreen)
>   {
>   	return "AMD";
>   }
>   
>   static const char* r600_get_chip_name(struct r600_common_screen *rscreen)
>   {
>   	switch (rscreen->info.family) {



More information about the mesa-dev mailing list