[Mesa-dev] [PATCH 0/8] radeonsi: implement missing indirect draw features

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Mon Aug 8 16:17:55 UTC 2016


For patch 1-7:

Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

For patch 8, you probably also want to add the extensions to the
release notes. With that added, it looks good to me too.

- Bas

On Mon, Aug 8, 2016 at 5:55 PM, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
> Hi,
>
> this series adds some bug fixes and small extensions related to indirect
> draws that we can now use. As with the recent changes, it only applies
> with sufficiently new firmware, which means that it only works with amdgpu
> (due to a lack of firmware version query in the radeon kernel module).
> Please review!
>
> Thanks,
> Nicolai
> --
>  docs/GL3.txt                                 |  4 +-
>  .../drivers/radeonsi/si_descriptors.c        |  8 ++--
>  src/gallium/drivers/radeonsi/si_pipe.c       |  8 ++--
>  src/gallium/drivers/radeonsi/si_pipe.h       |  3 +-
>  src/gallium/drivers/radeonsi/si_shader.c     | 13 +++++-
>  src/gallium/drivers/radeonsi/si_shader.h     |  4 +-
>  src/gallium/drivers/radeonsi/si_state_draw.c | 43 ++++++++++++++----
>  src/gallium/drivers/radeonsi/sid.h           |  3 ++
>  8 files changed, 65 insertions(+), 21 deletions(-)
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list