[Mesa-dev] [PATCH] dri: use 'bool' instead 'int' for boolean variables

[⚛]

On Mon, Aug 8, 2016 at 7:14 PM, Ian Romanick <idr at freedesktop.org> wrote:
> On 08/08/2016 09:38 AM, ⚛ wrote:
>> On Mon, Aug 8, 2016 at 6:22 PM, Ian Romanick <idr at freedesktop.org> wrote:
>>> I'm pretty sure this breaks ABI.  Did you try using an unpatched libGL
>>> with a patched *_dri.so (and vice-versa)?
>>
>> Can you be more specific?
>
> Eh... build Mesa.  Save the libGL and *_dri.so.  Apply patch.  Build
> again.  Run applications with LD_PRELOAD and LIBGL_DRIVERS_PATH (or
> EGL_DRIVERS_PATH) set to mix the old and new.

- The changes to the data structures in the patch do not necessarily
imply that mixing-unpatched-patched libs will fail because the
alignment of fields might stay the same.

- I looked into it a bit, but more time is required before I can send
the next version of the patch (if required). I marked the patch as
"deferred" at patchwork.freedesktop.org for now.

PS: Patches 10474 10427 10418 at patchwork aren't controversial so it
should be possible to review+merge them relatively quickly. It will
allow me to move on.