[Mesa-dev] [PATCH 3/3] anv/gen7_pipeline: Set multisample state using shared function

Jason Ekstrand jason at jlekstrand.net
Tue Aug 9 00:09:31 UTC 2016


Does this fix any tests?  If so, we should say so in the commit message.
With that updated,

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

On Mon, Aug 8, 2016 at 2:57 PM, Anuj Phogat <anuj.phogat at gmail.com> wrote:

> Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
> ---
>  src/intel/vulkan/gen7_pipeline.c | 16 +---------------
>  1 file changed, 1 insertion(+), 15 deletions(-)
>
> diff --git a/src/intel/vulkan/gen7_pipeline.c b/src/intel/vulkan/gen7_
> pipeline.c
> index 5395e79..17d7ccc 100644
> --- a/src/intel/vulkan/gen7_pipeline.c
> +++ b/src/intel/vulkan/gen7_pipeline.c
> @@ -81,21 +81,7 @@ genX(graphics_pipeline_create)(
>                       pCreateInfo->pRasterizationState, extra);
>     emit_3dstate_streamout(pipeline, pCreateInfo->pRasterizationState);
>
> -   if (pCreateInfo->pMultisampleState &&
> -       pCreateInfo->pMultisampleState->rasterizationSamples > 1)
> -      anv_finishme("VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_
> STATE_CREATE_INFO");
> -
> -   uint32_t samples = 1;
> -   uint32_t log2_samples = __builtin_ffs(samples) - 1;
> -
> -   anv_batch_emit(&pipeline->batch, GENX(3DSTATE_MULTISAMPLE), ms) {
> -      ms.PixelLocation        = PIXLOC_CENTER;
> -      ms.NumberofMultisamples = log2_samples;
> -   }
> -
> -   anv_batch_emit(&pipeline->batch, GENX(3DSTATE_SAMPLE_MASK), sm) {
> -      sm.SampleMask = 0xff;
> -   }
> +   emit_ms_state(pipeline, pCreateInfo->pMultisampleState);
>
>     const struct brw_vs_prog_data *vs_prog_data =
> get_vs_prog_data(pipeline);
>
> --
> 2.5.5
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160808/98e5d6b0/attachment.html>


More information about the mesa-dev mailing list