[Mesa-dev] [PATCH 3/3] gallium: Add c99_compat.h to u_bitcast.h

[Brian Paul]

On 08/09/2016 07:46 AM, Brian Paul wrote:
> On 08/09/2016 12:30 AM, Mathias Fröhlich wrote:
>> Hi Brian,
>>
>>  > I don't know why my local build is failing while appveyor and our
>>
>>  > in-house automated build seem OK. But applying your patch 3 alone
>> fixes
>>
>>  > things for me.
>>
>> As it fixes something independent, should I push that already?
>
> Sure.  For 1 & 3,
> Reviewed-by: Brian Paul <brianp at vmware.com>
> Tested-by: Brian Paul <brianp at vmware.com>
>
>
>>
>>  > Yeah, I applied your whole series and the MSVC build seems OK.
>> However,
>>
>>  > I'm hitting a new runtime crash (even after fixing the unrelated issue
>>
>>  > from Marek's rewrite of the state tracker validation code). It looks
>>
>>  > like patch 2/3 is the problem. I'll try to dig deeper tomorrow...
>>
>> Hmm, that part is meant as a nice addition on top, once we are at it.
>>
>> But, if this patch is a problem then I am probably off by one in the
>> returned
>>
>> index. You may 'return index + 1;' instead of just index.
>
> I'll let you know soon...

Yes, we need to add one to the index.  I'll re-test that patch when you 
update it.

-Brian