[Mesa-dev] [PATCH 23/32] i965/blorp: Stop setting point and line rasterization rules

Jason Ekstrand jason at jlekstrand.net
Thu Aug 11 21:15:20 UTC 2016


Blorp never uses points or lines and the default values of 0 are perfectly
fine.  Explicitly setting them is just noise.
---
 src/mesa/drivers/dri/i965/gen6_blorp.c | 2 --
 src/mesa/drivers/dri/i965/gen7_blorp.c | 2 --
 src/mesa/drivers/dri/i965/gen8_blorp.c | 4 +---
 3 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/gen6_blorp.c b/src/mesa/drivers/dri/i965/gen6_blorp.c
index 7d37ea3..78e9472 100644
--- a/src/mesa/drivers/dri/i965/gen6_blorp.c
+++ b/src/mesa/drivers/dri/i965/gen6_blorp.c
@@ -235,8 +235,6 @@ gen6_blorp_emit_wm_config(struct brw_context *brw,
    default:
       unreachable("not reached");
    }
-   dw5 |= GEN6_WM_LINE_AA_WIDTH_1_0;
-   dw5 |= GEN6_WM_LINE_END_CAP_AA_WIDTH_0_5;
    dw5 |= (brw->max_wm_threads - 1) << GEN6_WM_MAX_THREADS_SHIFT;
    dw6 |= 0 << GEN6_WM_BARYCENTRIC_INTERPOLATION_MODE_SHIFT; /* No interp */
    dw6 |= (params->wm_prog_data ? prog_data->num_varying_inputs : 0) <<
diff --git a/src/mesa/drivers/dri/i965/gen7_blorp.c b/src/mesa/drivers/dri/i965/gen7_blorp.c
index 1b9c853..1286b55 100644
--- a/src/mesa/drivers/dri/i965/gen7_blorp.c
+++ b/src/mesa/drivers/dri/i965/gen7_blorp.c
@@ -261,8 +261,6 @@ gen7_blorp_emit_wm_config(struct brw_context *brw,
    default:
       unreachable("not reached");
    }
-   dw1 |= GEN7_WM_LINE_AA_WIDTH_1_0;
-   dw1 |= GEN7_WM_LINE_END_CAP_AA_WIDTH_0_5;
    dw1 |= 0 << GEN7_WM_BARYCENTRIC_INTERPOLATION_MODE_SHIFT; /* No interp */
 
    if (params->wm_prog_data)
diff --git a/src/mesa/drivers/dri/i965/gen8_blorp.c b/src/mesa/drivers/dri/i965/gen8_blorp.c
index 2e90438..2223b23 100644
--- a/src/mesa/drivers/dri/i965/gen8_blorp.c
+++ b/src/mesa/drivers/dri/i965/gen8_blorp.c
@@ -270,9 +270,7 @@ gen8_blorp_emit_wm_state(struct brw_context *brw)
 {
    BEGIN_BATCH(2);
    OUT_BATCH(_3DSTATE_WM << 16 | (2 - 2));
-   OUT_BATCH(GEN7_WM_LINE_AA_WIDTH_1_0 |
-             GEN7_WM_LINE_END_CAP_AA_WIDTH_0_5 |
-             GEN7_WM_POINT_RASTRULE_UPPER_RIGHT);
+   OUT_BATCH(0);
    ADVANCE_BATCH();
 }
 
-- 
2.5.0.400.gff86faf



More information about the mesa-dev mailing list