[Mesa-dev] [PATCH v2 3/4] gallium/winsys/kms: Move display target handle lookup to separate function (v2)

[Tomasz Figa]

On Fri, Aug 12, 2016 at 8:03 AM, Jordan Justen
<jordan.l.justen at intel.com> wrote:
> On 2016-08-08 01:55:18, Tomasz Figa wrote:
>>    On Fri, Aug 5, 2016 at 2:37 AM, Jordan Justen <jordan.l.justen at intel.com>
>>    wrote:
>>
>>      On 2016-08-02 03:46:27, Tomasz Figa wrote:
>>      > +kms_sw_displaytarget_lookup(struct kms_sw_winsys *kms_sw,
>>      > +                            unsigned int kms_handle)
>>
>>      I don't think the 'lookup' name is appropriate, since it has the
>>      ref-count side effect. Instead of 'lookup', how about import, or
>>      find_and_import or something similar?
>>
>>    How about "get_by_handle"? IMHO "import" is kind of confusing, because the
>>    function doesn't end up creating any new objects, but instead just looks
>>    through already known ones.
>
> How about find_and_ref?

Sounds good to me. :)

Best regards,
Tomasz