[Mesa-dev] [PATCH 1/2] i965: remove unnecessary `if`

Eric Engestrom eric.engestrom at imgtec.com
Mon Aug 15 14:16:12 UTC 2016


	if (x) return true; else return false;
can be simplified as:
	return x;
since both `x` are already boolean expressions.

Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
---
 src/mesa/drivers/dri/i965/intel_screen.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c
index ae51c40..cef6005 100644
--- a/src/mesa/drivers/dri/i965/intel_screen.c
+++ b/src/mesa/drivers/dri/i965/intel_screen.c
@@ -603,13 +603,9 @@ intel_query_image(__DRIimage *image, int attrib, int *value)
       *value = image->planar_format->components;
       return true;
    case __DRI_IMAGE_ATTRIB_FD:
-      if (drm_intel_bo_gem_export_to_prime(image->bo, value) == 0)
-         return true;
-      return false;
+      return drm_intel_bo_gem_export_to_prime(image->bo, value) == 0;
    case __DRI_IMAGE_ATTRIB_FOURCC:
-      if (intel_lookup_fourcc(image->dri_format, value))
-         return true;
-      return false;
+      return intel_lookup_fourcc(image->dri_format, value);
    case __DRI_IMAGE_ATTRIB_NUM_PLANES:
       *value = 1;
       return true;
-- 
2.9.2



More information about the mesa-dev mailing list