[Mesa-dev] [PATCH 00/32] i965/blorp: Use genxml for state setup

[Jason Ekstrand]

On Sun, Aug 14, 2016 at 11:53 PM, Kenneth Graunke <kenneth at whitecape.org>
wrote:

> On Thursday, August 11, 2016 2:14:57 PM PDT Jason Ekstrand wrote:
> > This patch series is the next on the way towards generalizing blorp for
> > usin in Vulkan.  At this point, I'd say the project is about 80%
> complete.
> > This series only applies on top of the last two blorp isl series which
> are
> > still undergoing review.
> >
> > Patches 1-11 make minor genxml improvements.  Some of this is to make
> gen6
> > better and more like gen7-9.  The others are just general improvements
> that
> > made converting blorp easier.
> >
> > Patches 12-14 make a few minor changes to i965 so that we can include
> > brw_state.h and brw_context.h without brw_defines.h.
> >
> > Patches 15-23 re-arrange the state setup code in blorp to make the
> > different gens emit the packets more-or-less in the same order.  This was
> > very helpful when trying to debug problems when switching to genxml
> because
> > there should not be substantial changes in the batch between patch 23 and
> > the end of the series.
> >
> > Patches 24-32 convert all of the blorp state setup to using genxml in a
> > single file that gets recompiled 5 times, one for each gen.  I'm
> extremely
> > happy with the end result where almost all of the code is shared across
> > gens.  The one exception is WM and SF setup which is so different that we
> > really need different code for gen6, gen7, and gen8.
> >
> > This series can be found here:
> >
> > https://cgit.freedesktop.org/~jekstrand/mesa/log/?h=review/blorp-genxml
> >
> > Cc: Topi Pohjolainen <topi.pohjolainen at intel.com>
> >
> > Jason Ekstrand (32):
> >   genxml/gen6: Add uint MOCS fields for most things
> >   genxml/gen6: Add a Surface Base Address field to HIER_DEPTH_BUFFER
> >   genxml/gen6: Fix the length of 3DSTATE_WM
> >   genxml/gen6: Add the 3D_Prim_Topo_Type enum
> >   genxml/gen6: Make "Depth Clear Value" a uint
> >   genxml: Add a uint MOCS field to DEPTH_BUFFER packets
> >   genxml/gen6: Make SAMPLER_STATE look a bit more like gen7
> >   genxml: Make VERTEX_ELEMENT_STATE::Valid a bool
> >   genxml: Make a couple of VERTEX_BUFFER_STATE fields boolean
> >   genxml: Add a uint MOCS field to VERTEX_BUFFER_STATE
> >   genxml/gen9: Make 3DSTATE_SBE::AttributeActiveComponentFormat an array
> >   i965/state: Move is_drawing_lines/points to gen6_clip_state.c
> >   i965: Stop including brw_defines.h in brw_state.h
> >   i965: Roll intel_reg.h into brw_defines.h
> >   i965/blorp: Make gen6 VS and GS disable helpers static
>
> Patches 1-15 (the above) are:
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
>

Thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160815/3e31e295/attachment.html>