[Mesa-dev] Mesa stopped passing make check on August 10th: FAIL: glsl/glcpp/tests/glcpp-test

[darxus at chaosreigns.com]

Looks to me like src/compiler/glsl/glcpp/tests/120-undef-builtin.c.expected
just needs to be updated.


make check output includes:

============================================================================
Testsuite summary for Mesa 12.1.0-devel
============================================================================
# TOTAL: 9
# PASS:  8
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0
============================================================================
See src/compiler/test-suite.log
Please report to https://bugs.freedesktop.org/enter_bug.cgi?product=Mesa
============================================================================
Makefile:2308: recipe for target 'test-suite.log' failed
make[6]: *** [test-suite.log] Error 1
make[6]: Leaving directory '/home/darxus/source/mesa/src/compiler'


/home/darxus/source/mesa/src/compiler/test-suite.log says:

FAIL: glsl/glcpp/tests/glcpp-test
...
Testing ./glsl/glcpp/tests/120-undef-builtin.c... > /home/darxus/source/mesa/src/compiler/glsl/glcpp/tests/120-undef-builtin.c.out (./glsl/glcpp/tests/120-undef-builtin.c.expected) FAIL
--- ./glsl/glcpp/tests/120-undef-builtin.c.expected     2016-08-15 11:39:56.932734521 -0400
+++ /home/darxus/source/mesa/src/compiler/glsl/glcpp/tests/120-undef-builtin.c.out      2016-08-15 17:38:49.408473011 -0400
@@ -1,6 +1,3 @@
-0:1(1): preprocessor error: Built-in (pre-defined) macro names cannot be undefined.
-0:2(1): preprocessor error: Built-in (pre-defined) macro names cannot be undefined.
-0:3(1): preprocessor error: Built-in (pre-defined) macro names cannot be undefined.


git bisect run says:

91945f9e91e46aef79700015da032e16c355c96c is the first bad commit

Author:     Eric Anholt <eric at anholt.net>
AuthorDate: Tue Aug 9 00:02:44 2016 -0700
Commit:     Eric Anholt <eric at anholt.net>
CommitDate: Wed Aug 10 12:27:22 2016 -0700

    prog_hash_table: Convert compare funcs to match util/hash_table.h.
    
    I'm going to replace this hash table with util/hash_table.h, and the first
    step is to compare things the same way.
    
    Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
    Reviewed-by: Timothy Arceri <timothy.arceri at collabora.com>


Script I used with git bisect run:

git clean -xfd
./autogen.sh --enable-gles2 --disable-gallium-egl --with-egl-platforms=wayland,x11,drm --enable-gbm --enable-shared-glapi --with-gallium-drivers=r300,r600,swrast,nouveau,svga || exit 1
make || exit 1
make check || exit 1


$ git bisect log
git bisect start
# bad: [5d9b50e596c9d81c37ce0844ae0f8c9da3f6bea6] glx: apple specific occurences of dummyContext check
git bisect bad 5d9b50e596c9d81c37ce0844ae0f8c9da3f6bea6
# good: [1556f16e46ba3037c3901808c2e1ac5df8e2b20e] glsl: Fix the program resource names of gl_TessLevelOuter/Inner[].
git bisect good 1556f16e46ba3037c3901808c2e1ac5df8e2b20e
# good: [88c2fc6b2deca6ff54f37a100f6f0a0382f8049e] st/mesa: in ATI fs don't assume TEMP0=REG0
git bisect good 88c2fc6b2deca6ff54f37a100f6f0a0382f8049e
# bad: [33b38157731bb4e9b79edeb4f66213c66813248f] glsl/tests: fix segfault in uniform initializer test
git bisect bad 33b38157731bb4e9b79edeb4f66213c66813248f
# good: [4e8763cb0904c30d1962cf5ad52fe3a87be7b4bd] swr: [rasterizer core] split FE and BE stats
git bisect good 4e8763cb0904c30d1962cf5ad52fe3a87be7b4bd
# bad: [91945f9e91e46aef79700015da032e16c355c96c] prog_hash_table: Convert compare funcs to match util/hash_table.h.
git bisect bad 91945f9e91e46aef79700015da032e16c355c96c
# good: [2eae02f77c66e9a392dd8c2dc459ddc943e30140] swr: [rasterizer common] add linux definition for InterlockedAdd64
git bisect good 2eae02f77c66e9a392dd8c2dc459ddc943e30140
# good: [9aa75e5d46b9c2cf4eba2c182874a86ea9f5464a] swr: [rasterizer jitter] add core string to JitManager
git bisect good 9aa75e5d46b9c2cf4eba2c182874a86ea9f5464a
# good: [60f1b436b96f39f05af28348f997b089558574e6] nir: Drop an unused program/hash_table.h include.
git bisect good 60f1b436b96f39f05af28348f997b089558574e6
# first bad commit: [91945f9e91e46aef79700015da032e16c355c96c] prog_hash_table: Convert compare funcs to match util/hash_table.h.

Bisecting (not including the first good and bad commits), without make -j,
took me:
7573.34user 541.59system 2:48:48elapsed 80%CPU (0avgtext+0avgdata 410704maxresident)k