[Mesa-dev] [PATCH] glx: Don't use current context in __glXSendError

[Tapani Pälli]

On 08/16/2016 10:23 AM, Michel Dänzer wrote:
> On 16/08/16 04:11 PM, Tapani Pälli wrote:
>> On 08/16/2016 09:49 AM, Michel Dänzer wrote:
>>> From: Michel Dänzer <michel.daenzer at amd.com>
>>>
>>> There's no guarantee that there is one, and we don't need one anyway.
>>>
>>> Fixes piglit tests:
>>>
>>> glx at glx-fbconfig-bad
>>
>> this one passes for me with and without the patch
>
> Does your Mesa build have assertions enabled? (May require --enable-debug)

Ah right, yeah glx-fbconfig-bad gets hit. For the others I don't see 
difference in results.

>
>>> glx at glx_ext_import_context@import context, multi process
>>> glx at glx_ext_import_context@import context, single process
>>
>> these 2 fail for me with and without the patch (and have been failing
>> already before 2e3f067458e4) ... do these all pass for you before that
>> change?
>
> Yes, they did. (Using the radeonsi driver with DRI3)

I'm using DRI2.

>
> Anyway, forgetting about piglit for a second, can you agree that the
> code change makes sense per se? :)
>

Sure, context does not seem to be needed there so I do agree with the 
changes;

Reviewed-by: Tapani Pälli <tapani.palli at intel.com>

// Tapani