[Mesa-dev] [PATCH v2 2/2] util: add assert that key cannot be NULL on insertion

Jason Ekstrand jason at jlekstrand.net
Fri Aug 19 13:29:12 UTC 2016


Seems reasonable,

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

On Fri, Aug 19, 2016 at 5:02 AM, Tapani Pälli <tapani.palli at intel.com>
wrote:

> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
> ---
>  src/util/hash_table.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/util/hash_table.c b/src/util/hash_table.c
> index 4cfe3d9..9e643af 100644
> --- a/src/util/hash_table.c
> +++ b/src/util/hash_table.c
> @@ -295,6 +295,8 @@ hash_table_insert(struct hash_table *ht, uint32_t hash,
>     uint32_t start_hash_address, hash_address;
>     struct hash_entry *available_entry = NULL;
>
> +   assert(key != NULL);
> +
>     if (ht->entries >= ht->max_entries) {
>        _mesa_hash_table_rehash(ht, ht->size_index + 1);
>     } else if (ht->deleted_entries + ht->entries >= ht->max_entries) {
> --
> 2.7.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160819/d73e9b57/attachment.html>


More information about the mesa-dev mailing list