[Mesa-dev] [PATCH] mesa: Fix fixed function spot lighting on newer hardware (again)

Daniel Scharrer daniel at constexpr.org
Sat Aug 20 03:22:14 UTC 2016


On 2016-08-14 06:38, Matt Turner wrote:
> On Sat, Aug 13, 2016 at 5:07 PM, Daniel Scharrer <daniel at constexpr.org> wrote:
>> This was first fixed in commit b3f9c5c and then broken again in commit
>> fe2d2c7, which removed the abs modifier from input registers.
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91342
>> Signed-off-by: Daniel Scharrer <daniel at constexpr.org>
>> Cc: "12.0" <mesa-stable at lists.freedesktop.org>
> 
> Thank you very much! I completely missed that.
> 
> Reviewed-by: Matt Turner <mattst88 at gmail.com>
> 
> I'll push it on Monday.

I have sent a slightly updated version of the patch:
https://patchwork.freedesktop.org/patch/106411/

> Perhaps we could make a piglit test to ensure this stays fixed in the
> future. Any ideas?

Here is my attempt, hope it's ok:
https://patchwork.freedesktop.org/patch/106413/

-- 
Daniel Scharrer
http://constexpr.org/


More information about the mesa-dev mailing list