[Mesa-dev] [PATCH v2] mesa: Fix fixed function spot lighting on newer hardware (again)

Matt Turner mattst88 at gmail.com
Sat Aug 20 03:46:57 UTC 2016


On Fri, Aug 19, 2016 at 8:44 PM, Matt Turner <mattst88 at gmail.com> wrote:
> On Fri, Aug 19, 2016 at 7:23 PM, Daniel Scharrer <daniel at constexpr.org> wrote:
>> This was first fixed in commit b3f9c5c and then broken again in commit
>> fe2d2c7, which removed the abs modifier from input registers.
>>
>> v2: Don't change the size of struct ureg.
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91342
>> Signed-off-by: Daniel Scharrer <daniel at constexpr.org>
>> Cc: "12.0" <mesa-stable at lists.freedesktop.org>
>
> Thanks.
>
> Reviewed-by: Matt Turner <mattst88 at gmail.com>
>
> I'll commit it this time! Committed as e1d9dcd81085.

Actually, it introduced a warning so I amended the commit -- it's
actually commit 16ef7ab5c1.

The warning was due to an additional '0,' in static const struct ureg
undef = { ... } because of the removal of the abs field.


More information about the mesa-dev mailing list