[Mesa-dev] [PATCH mesa] st/va: add missing mutex_unlock

[Zhang, Boyuan]

Hi Eric,

Thanks for catching it. The patch is Reviewed-by: Boyuan Zhang <boyuan.zhang at amd.com>

Regards,
Boyuan

-----Original Message-----
From: Eric Engestrom [mailto:eric.engestrom at imgtec.com] 
Sent: August-22-16 12:17 PM
To: Zhang, Boyuan
Cc: mesa-dev at lists.freedesktop.org; Koenig, Christian; Eric Engestrom
Subject: Re: [Mesa-dev] [PATCH mesa] st/va: add missing mutex_unlock

CC'ing Boyuan Zhang (author of the original patch), who got somehow removed from the CC list when sending my patch.


On Sun, Aug 21, 2016 at 10:11:48PM +0100, Eric Engestrom wrote:
> Fixes: c59628d11b134fc01638 ("st/va: enable dual instances encode by 
> sync surface")
> Signed-off-by: Eric Engestrom <eric at engestrom.ch>
> ---
>  src/gallium/state_trackers/va/surface.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/gallium/state_trackers/va/surface.c 
> b/src/gallium/state_trackers/va/surface.c
> index 012e48e..3ee1cdd 100644
> --- a/src/gallium/state_trackers/va/surface.c
> +++ b/src/gallium/state_trackers/va/surface.c
> @@ -106,8 +106,10 @@ vlVaSyncSurface(VADriverContextP ctx, VASurfaceID render_target)
>     pipe_mutex_lock(drv->mutex);
>     surf = handle_table_get(drv->htab, render_target);
>  
> -   if (!surf || !surf->buffer)
> +   if (!surf || !surf->buffer) {
> +      pipe_mutex_unlock(drv->mutex);
>        return VA_STATUS_ERROR_INVALID_SURFACE;
> +   }
>  
>     context = handle_table_get(drv->htab, surf->ctx);
>     if (!context) {
> --
> 2.9.3